grpc: resolve simple clippy warnings - #2848
Open
nathanielford wants to merge 1 commit into
Open
Conversation
nathanielford
marked this pull request as ready for review
September 9, 2026 15:54
nathanielford
force-pushed
the
refactor/clippy-warnings
branch
2 times, most recently
from
September 9, 2026 17:13
98dd9b5 to
6ffb150
Compare
Resolve simple warnings in the `grpc` crate across the following categories: - clippy::doc_markdown: add missing backticks and URL formatting in doc comments - clippy::semicolon_if_nothing_returned: add trailing semicolons to unit-returning expressions - clippy::unnecessary_semicolon: remove redundant trailing semicolons - clippy::elidable_lifetime_names: elide redundant lifetime annotations
nathanielford
force-pushed
the
refactor/clippy-warnings
branch
from
September 9, 2026 20:33
6ffb150 to
c3ca64e
Compare
Member
|
I haven't seen these come up before. How are you getting them? New version of clippy or what? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Clean up simple, non-invasive clippy warnings in the
grpccrate so development and pre-commit checks don't trip on unrelated warnings.Solution
Resolve simple warnings across 4 categories in
grpc/src:clippy::doc_markdown: Add missing backticks and angle brackets for URLs/identifiers in doc comments.clippy::semicolon_if_nothing_returned: Add trailing semicolons on statements returning unit (()).clippy::unnecessary_semicolon: Remove redundant semicolons.clippy::elidable_lifetime_names: Elide redundant lifetime annotations on method implementations.More complex lints (e.g.
clippy::large_enum_variant) are deferred.